Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Russell Theme renders block errors in the site editor on initial load #58787

Closed
jeyip opened this issue Dec 2, 2021 · 5 comments
Closed

Comments

@jeyip
Copy link
Contributor

jeyip commented Dec 2, 2021

Quick summary

When loading the Russell theme for the first time in the site editor, it renders with block errors.

Screen Shot 2021-12-01 at 3 48 10 PM

Steps to reproduce

  1. Apply branch to local calypso dev environment
  2. Visit http://calypso.localhost:3000/new/beta
  3. Enroll in the FSE beta
  4. Pick a free test domain
  5. Verify that Arbutus is a selectable theme
  6. Create a site with Arbutus enabled and smoke test the theme

What you expected to happen

On initial load, there are no block errors

What actually happened

On initial load, there are block errors

Reproducibility

Consistent

Notes

Related to #58663

@creativecoder
Copy link
Contributor

creativecoder commented Dec 4, 2021

Potential fix at D71041-code.

Note that it's very possible this issue exists with other themes with starter content saved before Nov 28th, when D70425-code was deployed. cc @Automattic/theam

@creativecoder creativecoder self-assigned this Dec 4, 2021
@creativecoder
Copy link
Contributor

Resolved by D71041-code

@creativecoder
Copy link
Contributor

Reopening, as there's another error showing for the Post Title block

image

TypeError: can't access property "rendered", h is undefined
    edit https://s0.wp.com/_static/??-eJylUe1uwyAMfKERL91X92Pas0CwIqcGMgz9ePu5mrJVmmhW7R/HnY8zB4fZDCkWjAVmriNFgbEqdJhHZTLCvt90910PrhJ7cJyGnWFy2eYTUPR47ALFbpI7uNVrEf3PBT0VI1Twtw/FgatHgUmgKpnlPN9SODvsXIpNXmEtxFfoNYegWa0JySNLS6M7z5ysh5CO1HT6Vi2HlnCSFDerLnq/avRRURuvpMGqNIP9yCTlYh1f/wxkDOemL4Gx0Wsce8J8+2ygMdvyt0eVu8StGTuTyah7SVMyMM0u2dz8va/m94SHpfj38NY/P7xstk/bx9fpE5ynTEM=:74
    Le https://s0.wp.com/wp-content/plugins/gutenberg-core/v12.0.1/vendor/react-dom.min.edd8b7a6.js?m=1624062436h:7
    Pj https://s0.wp.com/wp-content/plugins/gutenberg-core/v12.0.1/vendor/react-dom.min.edd8b7a6.js?m=1624062436h:10
    di https://s0.wp.com/wp-content/plugins/gutenberg-core/v12.0.1/vendor/react-dom.min.edd8b7a6.js?m=1624062436h:8
    Nj https://s0.wp.com/wp-content/plugins/gutenberg-core/v12.0.1/vendor/react-dom.min.edd8b7a6.js?m=1624062436h:8
    sc https://s0.wp.com/wp-content/plugins/gutenberg-core/v12.0.1/vendor/react-dom.min.edd8b7a6.js?m=1624062436h:8

@creativecoder creativecoder reopened this Dec 6, 2021
@zaguiini
Copy link
Contributor

zaguiini commented Dec 6, 2021

Reopening, as there's another error showing for the Post Title block

That is fixed in the latest version of Gutenberg. I saw that and simply running trunk fixes the problem. Other themes suffer from the same issue if the page title is empty or undefined.

@creativecoder
Copy link
Contributor

Thanks so much @zaguiini !

I've confirmed that when running Gutenberg trunk on the site I don't see the error... seems I can keep this closed after all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants