-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cover Block Overlay – Color no longer applied when adding / editing Cover blocks #57711
Comments
Thank you for flagging this @hgwaltney ! I think this was changed in a previous release of Gutenberg as I can't replicate it with 11.7.1, but I can't pinpoint when was this changed. cc @Automattic/flow-patrol-create I also asked here: p1636178892096800-slack-CBTN58FTJ |
Adding another report at 4433797-zd-woothemes |
The user replied on this ticket: #4431371-zen I have asked the user to send an example and maybe we can look into a CSS workaround if the issue persists. |
I responded as well to user in #4431371-zen. They have thousands of posts on their site, so this issue affects them in a substantial way. Also - I did some of my own testing and was not able to reproduce the issue. I created a test post on an Atomic site, added a cover block with a color overlay, and with nested paragraph and heading blocks, then published it. After reloading the post on the front end and the post in the editor, the color overlay remained intact. |
The user from 4431371-zd-woothemes shared a video and more details: Video.mov
|
Another case here, text color could not be changed 28161311-hc |
Created an upstream issue: WordPress/gutenberg#36310 |
Another report here: 32646497-hc Text color was also affected but using the highlight option in the block settings allowed us to set the text color properly. |
This issue is tracking an issue in another repository. All +1's of end-user reports should be done on this issue, while any discussion related to the issue itself and its fix should be done on the issue in the outside repository. |
reported in zd-4439451 |
Got another report of a website with the Dalston theme having issues with the 4441395-zd-woothemes We have another issue possibly related: p9cu9o-34L-p2 |
Another possible instance here: 30507333-hc |
Another report: 4441977-zen |
Another report: 32665748-hc For my case, the following CSS helped me force a 0 opacity to the cover block image while changing it to .8 when we hover over:
|
Another report: p1636470933430900-slack-C03TY6J1A |
Many theme demos have also broken causing low color contrast, especially the contact sections. For example, in Maywood demo: |
Encountered on 4445479-zd-woothemes Provided user with some CSS to get all of their cover blocks back to the default 0.5 opacity. User will want an update when this is fixed and when they can remove the custom CSS. |
The fix was included in the v11.9.1 patch release and it should be deployed to Simple and Atomic sites later today. |
Another report here: 4466102-zd-woothemes |
@WunderBart, would you be able to help us confirm if the fix was deployed as expected? Taking 4449926-zd-woothemes as an example, I'm seeing the correct
I should note that I'm unable to replicate this particular issue on a test site. Thanks for your help! @Automattic/bug-herders, I've added this to our bulk reply queue for us to deal with when we have a confirmed fix! 🙏 |
It appears that this issue is also affecting the Group Block.
|
Ran into this in 30888354-hc Showed how to use the Highlight tool to make the text on the cover block white that way. |
Had something similar in 32927342-hc / 4548270-zd They don't have the Cover Block at all though, they have the group block. Not sure if this is the same bug or not. |
@pbking as you mentioned in Automattic/themes#5011, do you believe that this issue is also part of a larger problem? |
Another report 4549872- ZD |
The issue seems to be resolved for 4449926-zd-woothemes :
Unsure which release actually did the fixing since 4449926-zd-woothemes has been on hold for a while. |
Another report in 30053228-hc -- white default text in the editor view, but dark grey on live site, which made it illegible against the background. I advised the user that the workaround solution was to manually apply the text color to their blocks inside the Cover block. |
Another interaction from #4448278-zd |
Sorry for the late reply, totally missed your ping, @inaikem! 🙈 AFAIK, the fix has been deployed as expected. Although, since the markup of the Cover block has changed, similar issue(s) might be appearing for some themes that provide customized styles for the Cover block. Would you be able to verify if the reporting user uses a specific theme that it might be related to? /cc @chad1008 |
Another report in 4638455-zen |
@essleeung I wasn't able to replicate this either. Is the issue visible on a public page on the users site? |
@glendaviesnz They had it set in their drafts for us to test and didn't want it on their live site. |
User affected by the issue reported that the temporal CSS fix they were given is not working anymore. |
Another user affected by this: 4895541-zen Gave CSS code for a temp fix: .wp-block-cover.is-style-hover-reveal:hover .has-background-dim { |
I've got another instance here: 34895673-hc |
I have tested this with several themes, older and newer and I can't replicate this anymore. I'm closing this for now as per p1653547485419459-slack-C01UW7SB411, but please reopen if you encounter other cases. cc @Automattic/dotcom-pa-group |
Quick summary
According to the Cover Block support doc in the Overlay section, the overlay color should default to grey. When adding new Cover blocks or editing existing ones, the overlay color is removed/unset and needs to be manually selected to add/restore overlay feature.
Steps to reproduce
OR
What you expected to happen
Overlay settings should default to grey color.
OR
Overlay settings should still hold previously set color.
What actually happened
No overlay color is selected by default. Increasing / decreasing opacity setting affects cover block text, but not the image overlay.
Existing Cover blocks no longer hold previously set color, as color selected is somehow deselected.
Context
#4431371-zen
Operating System
No response
Browser
No response
Simple, Atomic or both?
Simple, Atomic
Theme-specific issue?
No response
Other notes
No response
Reproducibility
No response
Severity
No response
Available workarounds?
Yes, easy to implement
Workaround details
The Cover block overlay color can be reselected in the block settings.
The text was updated successfully, but these errors were encountered: