-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Varia Themes: Cover block - text changes color upon editing anything on the same page #5181
Comments
This happens on the wpcourses.com website too. Editing any elements but Cover block on the page causes the text color on the Cover block to change too. Site: Atomic |
Hey! I tried to replicate this using Hever, Maywood and Geologist on my end, but I had no luck. Could you give it a second shot and if it still happens could you share a screen capture? |
I'm able to reproduce in Hever:
I was also able to reproduce this locally with Hever (downloaded from WPcom) activated, so this isn't WPcom specific. In this case I created the cover block on a default theme (Twenty Twenty if I recall correctly) which worked fine. I then edited the same post, added a paragraph block, and updated. This caused the color on the front end to change from white (matching the editor) to dark grey/black. I was also able to reproduce on another Varia child (Stratford). I was not able to reproduce when testing on some non-Varia child themes, so that may be worth investigating as others have noted. So, TLDR of my testing:
|
This also happened on an AT site running the theme Appetite in 33137529-hc. |
Doing some further testing on this - and shifting over to the themes repo as this seems related to Varia themes handling of colors in Cover blocks |
This issue is sounding really similar to #4993 - which is caused by the default text color for elements within Cover Blocks not matching within the editor and the front-end. It is as though the default text color for all blocks is changed to dark grrey. In that issue the problem is seen when first editing content in pages (compared to updating pages in this issue). In these cases my hypothesis is that the blocks were using the default color already. I suspect the same issue is at play - something about updating the page updateds the html/css definitions so the default color changes. |
Also reported in 4687419-zen @jordesign It seems like we're getting several issues that overlap so I'd like to understand if setting a high priority here would make sense. :) |
Other reports from Automattic/wp-calypso#60272:
|
I'd like to point out that in the above case the fonts were not applied either. |
I wanted to leave a comment here that this 4706374-zd-woothemes ticket was most likely not a bug, but a custom CSS that was added by the user and we didn't know about it, until now. |
Quick summary
Multiple users have reported that on live sites using the Cover block, the text has previously been white, and has since changed to grey or black (an unreadable color) after another unrelated element is edited.
has-background-dim
class is moved down one level from.wp-block-cover
to.wp-block-cover__gradient-background
. It seems likecolor: var(--wp--preset--color--background);
is set for both, though, so I have no idea what's happening there. All blocks inside still use inherit to get text color.Steps to reproduce
What you expected to happen
The text should stay white, as it does in the editor.
What actually happened
The text goes dark grey or black and is unreadable on a dark-overlay image.
Context
Most recently, 33065416-hc (AT) Also in 28882174-hc (Simple). Test site is available at hgshdfhasdfwerfas.wordpress.co — all I did to get that color change to trigger was change the Welcome to Maywood H3 to a H4.
Simple, Atomic or both?
Simple, Atomic
Theme-specific issue?
Both these sites are on Hever, but it might be broader than that! I haven't tested other themes.
Browser, operating system and other notes
No response
Reproducibility
Consistent
Severity
Some (< 50%)
Available workarounds?
Yes, easy to implement
Workaround details
Manually setting text color works, but it's not an easy alternative for sites with lots of cover images.
The text was updated successfully, but these errors were encountered: