Improve unit tests for React 17 PR (#56004)

* Wrap i18n locale with act in test * Add fake timers to ETK tests
Automattic · Sep 3, 2021 · e10d909 · e10d909
1 parent ae701d9
commit e10d909
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/apps/editing-toolkit/editing-toolkit-plugin/wpcom-block-editor-nux/src/test/store.test.js b/apps/editing-toolkit/editing-toolkit-plugin/wpcom-block-editor-nux/src/test/store.test.js
@@ -6,6 +6,7 @@ const STORE_KEY = 'automattic/wpcom-welcome-guide';
 
 beforeAll( () => {
 	register();
+	jest.useFakeTimers(); // Required for wait-for-expect to work.
 } );
 
 let originalFetch;

diff --git a/packages/i18n-calypso/test/use-translate.js b/packages/i18n-calypso/test/use-translate.js
@@ -17,7 +17,9 @@ describe( 'useTranslate()', () => {
 
 	beforeEach( () => {
 		// reset to default locale
-		i18n.setLocale();
+		act( () => {
+			i18n.setLocale();
+		} );
 
 		// create container
 		container = document.createElement( 'div' );
@@ -68,9 +70,11 @@ describe( 'useTranslate()', () => {
 
 	test( 'rerenders after update of current locale translations', () => {
 		// set some locale data
-		i18n.setLocale( {
-			'': { localeSlug: 'cs' },
-			'hook (%(lang)s)': [ 'háček (%(lang)s)' ],
+		act( () => {
+			i18n.setLocale( {
+				'': { localeSlug: 'cs' },
+				'hook (%(lang)s)': [ 'háček (%(lang)s)' ],
+			} );
 		} );
 
 		// render the Label component