Add new process payment exception #8834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
hsingyuc
changed the base branch from
develop
to
update/pass-previous-error-to-exception
hsingyuc
force-pushed
the
add/new-process-payment-exception
branch
2 times, most recently
from
7ba3671 to
e1ff53d
Compare
Base automatically changed from
update/pass-previous-error-to-exception
to
develop
May 22, 2024 18:10
hsingyuc
force-pushed
the
add/new-process-payment-exception
branch
2 times, most recently
from
1e2e54f to
6e1c366
Compare
hsingyuc
requested review from
a team and
leonardola
and removed request for
a team
hsingyuc
force-pushed
the
add/new-process-payment-exception
branch
from
e7a457f to
80a2ccf
Compare
|
@leonardola I fixed the unit test and this PR is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
This PR is an extension of the Pass previous Exception with Exception PR. The new_process_payment is still on dev mode only but I think it's still good to have it early on.
The new_process_payment is being used outside of the
tryso this PR pass theNew_Process_Payment_Exceptionas previous error with the exception thrown in thenew_process_payment, so we can use the previous class added in the $additional_data in WC whennew_process_paymentis compatible with Blocks checkout.Note:
new_process_paymentis incompatible with Blocks checkout.Testing instructions
new_process_paymentis incompatible with Blocks checkout.truethrow new Exception( __( 'The payment process could not be completed.', 'woocommerce-payments' ), 0, new New_Process_Payment_Exception() );innew_process_payment.process_checkoutThe payment process could not be completed.on the checkout pageWCPay\Exceptions\New_Process_Payment_Exceptionnpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge