Expose WCPay refund transaction id for refund endpoint #7932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
anu-rock
reviewed
Dec 21, 2023
There was a problem hiding this comment.
Manual testing worked well 🎉
Review checklist
| Parameter | Result |
|---|---|
| Approach | ✅ All good |
| Implementation | ✅ All good |
| Automated tests | ✅ All good |
| Naming | 👍 Almost good (left comments) |
| Typing | 👍 Almost good (left a comment) |
| Code comments | ✅ All good |
| Changelog | 👍 Almost good (left a comment) |
| Testing instructions | ✅ All good |
| Demo (video or JN site) | ✅ All good |
| Manual testing | ✅ Works as expected |
anu-rock
approved these changes
Jan 4, 2024
mordeth
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7857
Changes proposed in this Pull Request
Expose refund transaction id for the refund API endpoint. The transaction id is saved on the refund order in the metadata, with
_refund_transaction_idkey.Testing instructions
_refund_transaction_idPayments -> Transactionsujshae.mov
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge