Introduce express checkout utilities class #7926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdmoore
requested review from
a team and
timur27
and removed request for
a team
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
timur27
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
It's great to see this area being incrementally improved, I remember some time ago we chatted in another GH issue on this. Great job @mdmoore! All the testing instructions are passing and shipping zone hint in the description (to reproduce the bug on develop) was super helpful ⚡
I'm leaving a few comments which shouldn't block the PR 👍
Unrelated to this PR
I've noticed that when not changing a discounted product count and going through the GPay flow, the original price is being shown and not the reduced price. I can reproduce it in develop and after a quick search in the backlog I want to create a new issue for this, but before I do this: may I ask you to quickly check if I'm right or not? Thank you!
includes/express-checkout/class-wc-payments-express-checkout-button-utils.php
Outdated
Show resolved
Hide resolved
includes/express-checkout/class-wc-payments-express-checkout-button-utils.php
Outdated
Show resolved
Hide resolved
includes/express-checkout/class-wc-payments-express-checkout-button-utils.php
Outdated
Show resolved
Hide resolved
|
Thanks @timur27!
Can you describe how you're discounting your product? I've tried by adding a sale price and via coupon code add on the cart page(which is not applied to express checkout) and the discounted price is reflected in the total. I'm happy to test further and help confirm this bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7694
Fixes #7801
Changes proposed in this Pull Request
This introduces a utility class for express checkout buttons such as the payment request buttons and WooPay buttons. There are several duplicated functions across the WooPay and Payment Request button handler class. The impetus for this refactor was the bug mentioned in #7588. Both express buttons are using the
wc_ajax_wcpay_add_to_carthook with an attachedajax_add_to_cartfunction. This leads to conflicts when both button types are enabled at the same time, with the WooPaywc_ajax_wcpay_add_to_cartalways being called. This PR moves that hook to a single location and calls a singlewc_ajax_wcpay_add_to_cartfunction from a utilities class.This will also serve as a good base to consolidate other duplicated functions among the two button handler classes as mentioned in 1545-gh-Automattic/woopay.
Testing instructions
developbranch, enable WooPay and Payment Request buttons.wc-ajax=wcpay_add_to_cartandwc-ajax=wcpay_get_shipping_optionsresponses.I remember having trouble reproducing this initially due my my shipping setup. As long as you're triggering a shipping zone/method with an address stored in Google, the issue should be present. I'm using a flat rate of $1.
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge