Remove URL params from woopay_source_url #7924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +170 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
alefesouza
requested changes
Dec 15, 2023
There was a problem hiding this comment.
Thanks for working on this @malithsen!
Just a few comments about plain permalinks, also this URL we send on the iframe shouldn't be updated too?
| @@ -73,7 +73,9 @@ const CheckoutPageSaveUser = ( { isBlocksCheckout } ) => { | |||
| ? {} | |||
| : { | |||
| save_user_in_woopay: isSaveDetailsChecked, | |||
| woopay_source_url: window.location.href, | |||
| woopay_source_url: window.location.href.split( | |||
There was a problem hiding this comment.
This would not work with plain permalinks, maybe we can change it to wcSettings.storePages.checkout.permalink.
There was a problem hiding this comment.
Great catch! Updated in abbd2a4
I wasn't sure if storePages would be available on all sites. Then realized that it's set in Blocks. Since Blocks is packaged with WooPayments we should be good.
| @@ -291,7 +293,7 @@ const CheckoutPageSaveUser = ( { isBlocksCheckout } ) => { | |||
| <input | |||
| type="hidden" | |||
| name="woopay_source_url" | |||
| value={ window.location.href } | |||
| value={ window.location.href.split( '?' )[ 0 ] } | |||
|
Thanks for the review @alefesouza
Yeah, good catch. Updated in b85428d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
woopay_source_urlthat is used to track WooPay marketing consents, currently store the complete URL. This can break checkout when a store appends URL params and the URL is very long.This PR removes the URL parameters in the URL to reduce its length.
Testing instructions
To replicate URLs with params
http://wcpay.test/checkout/?param1=value¶m2=value2
To replicate checkout error with long URLs.
Test the fix
platform_checkout_source_urlmetafield.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge