-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add E2E tests for merchant multi-currency setup #7918
Add E2E tests for merchant multi-currency setup #7918
Conversation
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: 0 B Total Size: 1.26 MB ℹ️ View Unchanged
|
835ed55
to
22a9697
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and tests well. I left a couple of comments but approving since they're really minor.
- e2e tests pass locally ✅
- e2e tests pass in the CI ✅
tests/e2e/specs/wcpay/merchant/merchant-admin-multi-currency-setup.spec.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and tests well. I left a couple of comments but approving since they're really minor.
- e2e tests pass locally ✅
- e2e tests pass in the CI ✅
I'll proceed with merging this PR despite the errors in the JS tests check, as they seem to be linked to a different PR. |
Closes #7382
Changes proposed in this Pull Request
Implement E2E tests for multi-currency setup functionality, including:
Testing instructions
npm run test:e2e merchant-multi-currency-setup.spec.js
.npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge