Add test mode notice in page order detail. #7898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +140 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
|
Note: all test failures are related to Update: also be ready to get reviews. |
jessy-p
reviewed
Dec 20, 2023
There was a problem hiding this comment.
- Fix conflicts
Other nitpicks:
- Can add tests for the component to check that the modal displays.
- Can use the key
WCPAY_MODE_META_KEYinstead ofWCPAY_MODE_KEYfor two reasons:
- Follows the pattern already followed inWC_Payments_Order_Servicefor other keys
- Jumps out to me easier in lines like
\WCPay\Constants\Order_Mode::TEST === $order->get_meta( WC_Payments_Order_Service::WCPAY_MODE_KEY )where we have theOrder_Modeand theWC_Payments::mode()in addition to the meta_key
# Conflicts: # client/order/index.js # includes/admin/class-wc-payments-admin.php
|
👋 @jessy-p Thanks for the feedback. I addressed for other comments except this one:
Actually, this is NOT a modal being triggered in a specific event such as |
jessy-p
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #334
Changes proposed in this Pull Request
Use the same foundation of Show active dispute as inline notice in order edit screen #6373 to add a new notice for test mode in the order details. Changes for this in the JS change files, and this PHP code
woocommerce-payments/includes/admin/class-wc-payments-admin.php
Line 737 in 25d96a5
I also use this opportunity to introduce
Order_Modeconstant (enum) class, andWC_Payments_Order_Service::WCPAY_MODE_KEY. Changes for this is for the rest of PHP files.Testing instructions
Screenshots
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge