-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use CardNotice component for authorization notification in transaction details page #7891
Use CardNotice component for authorization notification in transaction details page #7891
Conversation
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: -42 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I miss a few things in this PR:
- changelog
- testing instruction for fraud prevention case
Thanks @kalessil. Changelog added. I also tried to add testing instructions for fraud prevention rules as explained in this PR #5888, but no luck. The thing is that the payment lands in the blocked state after I set up the fraud prevention rule. So I updated the testing instructions to explain how to force the flag that controls the fraud prevention case. |
…hub.com:Automattic/woocommerce-payments into fix/7748-capture-notification-styles-are-broken
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tests well.
Fixes #7748
Changes proposed in this Pull Request
Before
After
Testing instructions
To test an authorization that is blocked by fraud rules you can force
isFraudOutcomeReview
flag. Inclient/payment-details/summary/index.tsx
:Authorization blocked by fraud rules
npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge