Streamline checkout classes #7869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timur27
changed the base branch from
develop
to
cleanup/is-upe-enabled-logic
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
added 5 commits
December 12, 2023 07:37
timur27
force-pushed
the
cleanup/upe-checkout-class
branch
from
9239f77 to
c239163
Compare
added 9 commits
December 12, 2023 11:07
… and increase test coverage
timur27
force-pushed
the
cleanup/upe-checkout-class
branch
2 times, most recently
from
21d1935 to
a9eb6b2
Compare
timur27
force-pushed
the
cleanup/upe-checkout-class
branch
2 times, most recently
from
2991b22 to
7ceff11
Compare
timur27
force-pushed
the
cleanup/upe-checkout-class
branch
from
3cf2d34 to
ce1de59
Compare
timur27
force-pushed
the
cleanup/upe-checkout-class
branch
from
bc4be8f to
3ea8609
Compare
timur27
requested review from
a team,
gpressutto5,
mdmoore and
brettshumaker
and removed request for
a team and
gpressutto5
mdmoore
reviewed
Dec 21, 2023
mdmoore
approved these changes
Dec 21, 2023
|
Merging due to reduced team capacity, and the PR still has one approval. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7783
Contributes to #6882 as per first bullet point here
Changes proposed in this Pull Request
This PR merges two checkout classes into one
Since the latest UPE rollout, only
WC_Payments_UPE_Checkoutwas used. It also used parent class methods in some places.As a result, in this PR
WC_Payments_Checkoutwhich was used inWC_Payments_UPE_Checkoutwas moved intoWC_Payments_UPE_CheckoutWC_Payments_Checkoutwas removedWC_Payments_Checkoutwas removed, as the previous two points led to this class being emptyWC_Payments_UPE_Checkoutwas renamed toWC_Payments_Checkoutto reduce complexity and improve readabilityAnother significant step forward was the unit tests refactoring and extension. Multiple dependencies to the checkout class within the gateway test suite made the tests mock their own units under test. Checkout classes were used in unit tests for gateways, where we directly or indirectly tested their implementation from the gateway level, which is wrong. This PR improves this and to confirm this, you might try to search for
WC_Payments_Checkoutin test files and find that it's being used only in the test suite which is supposed to test checkout. Also a few new test cases were added totest-class-wc-payments-checkout.php.Changes and testing instructions
save payment methodcheckbox is displayed for logged in user for card PM and is not displayed for other, non reusable PMsnpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge