Rename dispute action from acceptTransactionDetailsDispute() to acceptDispute()
#7456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DetailsDispute()` to `acceptDispute()`.
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: -657 B (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
shendy-a8c
changed the title
acceptTransactionDetailsDispute() to acceptDispute()
5 tasks
6 tasks
Jinksi
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Nice one @shendy-a8c 🙌
I've confirmed:
- accepting a dispute on the Transaction Details screen works as expected
- the redirect from Dispute details → Transaction details works as expected
I've looked at the failing e2e test and it is unrelated to this PR:
FAIL tests/e2e/specs/wcpay/merchant/merchant-orders-status-change.spec.js
Co-authored-by: Eric Jinks <[email protected]>
|
I have approved #7458 and this PR is ready to merge ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #7363
Changes proposed in this Pull Request
acceptTransactionDetailsDispute()toacceptDispute().acceptDispute()calls that got passed dispute id and change it so we pass dispute object because the new (renamed fromacceptTransactionDetailsDispute())acceptDispute()now accepts a dispute object instead of dispute id.Testing instructions
The action rename affects useDispute() hook and that hook is used in client/disputes/details/index.tsx. This can be ignored because we're removing the legacy dispute details (part of #7363).
The rename also affects client/disputes/redirect-to-transaction-details/index.tsx, so we need to test that redirection from dispute details page to transaction details page still works.
4000000000000259that will trigger a dispute.Also
nb: as per the time of this writing,
merchant-orders-status-change.spec.jstest has been failing. Likely it's due to the change outside of this PR as I see that test fails in other PRs as well.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge