Fix MultiCurrency onboarding settings page on Woo Express #7361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
jessepearson
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6466
Changes proposed in this Pull Request
This PR aims to fix the MultiCurrency onboarding settings page on Woo Express that was rendering the debug statistics due to broken HTML being output. The HTML was broken due to the lack of a
sectionendwith the sameidas thetitlesection.Proposed changes:
sectionendsectionSave settingsbutton as it doesn't make sense on that pageThe page content gets mixed with the MC settings without the
sectionendsection, which causes the debug tool to be rendered with the MC settings. After adding the new section, the settings page knows where to close the tags, and the page gets rendered correctly.Testing instructions
Before checking out to this branch
#querylistdiv is inside the#mainformform#querylistdiv on the developer tools and confirm that the debug bar HTML is thereDeveloper tools
Developer tools
Test it on the Woo Express site
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge