Moving hook initialisation functions out of constructors #7355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sts and ruleset accordingly.
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
marcinbot
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Looks good, but I haven't smoke-tested.
Compare the changeset for the WCPay_Account class - I slightly altered the order of actions/filters to order them more logically, but we should double check to make sure nothing went wrong.
This also appears fine.
It's a 
from me once we smoke test
oaratovskyi
approved these changes
Oct 4, 2023
…oks-from-constructors
…Automattic/woocommerce-payments into dev/7262-remove-hooks-from-constructors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7262
Changes proposed in this Pull Request
Remove hook initialisation out of constructors for the
WCPay_Account,*_Onboarding_Serviceand*_Incentive_Service.Testing instructions
WCPay_Accountclass - I slightly altered the order of actions/filters to order them more logically, but we should double check to make sure nothing went wrong.npm run listen, disconnect the currently connected account on the store, perform an onboarding, clear the cache. Ensure everything in the admin area looks good. Make a test purchase, and make sure it displays properly on thePayments > Transactionspage.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge