Hide helper text related to Storefront theme in Multi-Currency settings when Storefront is not the active theme #7336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen Storefront is not the active theme
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: -16 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
jessepearson
changed the title
|
@jessepearson I think the same problem also may exist on the MC onboarding page. Can you also fix that in this PR, so we don't return back to this in the future? |
This was updated in this PR, that's what this is: https://github.com/Automattic/woocommerce-payments/pull/7336/files#diff-c7982e2ab02e0f981c2af11408001d8051a877370c9226be0c57c786311aba5cL130 You're referring to the wizard at |
|
Yes, I'm referring to that file, sorry missed that one. I'll review this in a couple. |
No worries. I am not sure how often that wizard is even used. |
tpaksu
approved these changes
Oct 4, 2023
|
Yep, I can see the change. Thanks for fixing this! 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6182
Changes proposed in this Pull Request
This PR will hide the helper text that went with the checkbox to enable the currency switcher on the Storefront theme:
trueresponse to be later so that it includes thedivthat holds the helper text.Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.