Update Name Your Price compatibility to use new Compatibility methods #7269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te code accordingly.
jessepearson
added
the
component: customer multi-currency
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
@helgatheviking I just sent you a DM in slack with a link to a zip file, can you check it out and see if all the expected functionality is there? It takes the edits in the PR (which are copied from your PR #7172 ) and adds them on top of my other changes I've done. |
|
@jessepearson lgtm |
|
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
3 tasks
fashuvo
reviewed
Oct 2, 2023
…2-nyp-cart-editing
…2-nyp-cart-editing
tpaksu
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Tested various scenarios with the NYP plugin, and all tests passed:
- Added only the NYP product to the cart
- Added another regular product alongside the NYP product
- Tested changing currencies on the cart
- Tested changing currencies on the edit price page
- Tested changing currencies after editing the price
- Tested changing currencies on the checkout page
And all showed the correct price. Thanks for working on this!
LGTM, 🚢 it!
6 tasks
Base automatically changed from
fix/5524-price-conversion-helper-function
to
develop
October 4, 2023 12:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5524 #7172
Changes proposed in this Pull Request
This PR is the second part of #7202 that uses the new methods in order to allow Name Your Price amounts to be able to be switched on the cart and checkout pages.
Adds param to the "Edit price" link for a NYP product in the cart. When clicked the user is redirected back to the product page with the current price pre-filled. If the user switches the currency at this point the pre-filled price will not change until this patch is implemented.
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.