Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Shopper Subscriptions Purchase Sign Up Fee spec to Playwright #10160

Conversation

ismaeldcom
Copy link
Contributor

Fixes #10089

Changes proposed in this Pull Request

  • Implement placeOrderWithOptions to simplify specs, allowing for placing orders with customs params like product ID and billing address.
  • Add goToSubscriptions to merchant navigation.
  • Implement Playwright shopper-subscriptions-purchase-sign-up-fee spec.
  • Remove Puppeteer shopper-subscriptions-purchase-sign-up-fee spec.

Testing instructions

  • Checkout dev/10089-convert-shopper-subscriptions-purchase-sign-up-fee-spec
  • Run npm run test:e2e-pw shopper-subscriptions-purchase-sign-up-fee
  • Test should pass locally.
  • Test should pass in GH actions.

  • Run npm run changelog to add a changelog file, choose patch to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.
  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Post merge

@ismaeldcom ismaeldcom self-assigned this Jan 16, 2025
@botwoo

This comment was marked as off-topic.

This comment was marked as off-topic.

@ismaeldcom ismaeldcom requested a review from a team January 16, 2025 08:04
Copy link
Contributor

@tpaksu tpaksu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests worked well locally. Left one comment that needs attention, but not so important. 🚢 it! Thanks for working on this.

@ismaeldcom ismaeldcom added this pull request to the merge queue Jan 16, 2025
Merged via the queue into develop with commit efe1065 Jan 16, 2025
25 checks passed
@ismaeldcom ismaeldcom deleted the dev/10089-convert-shopper-subscriptions-purchase-sign-up-fee-spec branch January 16, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E Playwright Migration: convert shopper-subscriptions-purchase-sign-up-fee spec
3 participants