Escape attributes added/edited in #8650 (#8787)

Co-authored-by: Guilherme Pressutto <[email protected]>
Automattic · May 6, 2024 · 5134e4c · 5134e4c
1 parent 10783bb
commit 5134e4c
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/assets/css/success.rtl.css b/assets/css/success.rtl.css
@@ -1,11 +1,15 @@
-.wc-payment-gateway-method-name-woopay-wrapper {
+.wc-payment-gateway-method-logo-wrapper {
 	display: flex;
 	align-items: center;
 	flex-wrap: wrap;
 	line-height: 1;
 }
 
-.wc-payment-gateway-method-name-woopay-wrapper img {
+.wc-payment-gateway-method-logo-wrapper img {
 	margin-left: 0.5rem;
 	padding-top: 4px;
 }
+
+.wc-payment-gateway-method-logo-wrapper.wc-payment-bnpl-logo img {
+	max-height: 30px;
+}
diff --git a/changelog/fix-escaping-from-8650 b/changelog/fix-escaping-from-8650
@@ -0,0 +1,5 @@
+Significance: patch
+Type: fix
+Comment: PR related to another issue already in changelog.
+
+
diff --git a/includes/class-wc-payments-order-success-page.php b/includes/class-wc-payments-order-success-page.php
@@ -136,8 +136,8 @@ public function show_bnpl_payment_method_name( $gateway, $payment_method ) {
 
 		ob_start();
 		?>
-		<div class="wc-payment-gateway-method-logo-wrapper wc-payment-bnpl-logo <?php echo $payment_method->get_id(); ?>">
-			<img alt="<?php echo $payment_method->get_title(); ?>" src="<?php echo esc_url_raw( $method_logo_url ); ?>">
+		<div class="wc-payment-gateway-method-logo-wrapper wc-payment-bnpl-logo <?php echo esc_attr( $payment_method->get_id() ); ?>">
+			<img alt="<?php echo esc_attr( $payment_method->get_title() ); ?>" src="<?php echo esc_url_raw( $method_logo_url ); ?>">
 		</div>
 		<?php
 		return ob_get_clean();