This repository has been archived by the owner on Jul 20, 2018. It is now read-only.
VIP Scanner: filter_files() now accepts arrays of file types. #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… efficient scanning. I made this change so that when searching for XSS vulnerabilities, I wouldn't have to run through two foreach ( $this->filter_files() ) blocks. One for php and one for html. It should make scanning multiple types at once much easier.
| return array(); | ||
| if ( $type ) { | ||
| if ( is_array( $type ) ) { | ||
| $file_types = array(); |
There was a problem hiding this comment.
The naming of this variable is confusing, as we're not storing an array of file types, but rather files themselves.
…iptive of its contents. The variable $file_types had a name that could cause confusion. Instead of storing file types, it stores files of multiple types (if $type is an array). I renamed it to $files_of_multiple_types to be more in line with what the variable contains.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be a solution to GitHub issue #265.
I made this change so that when searching for XSS vulnerabilities, I wouldn't have to run through two
foreach ( $this->filter_files() )blocks--one for PHP and one for HTML.It should make scanning multiple types at once much easier.