Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more options to be configured from repo options file. #143

Merged
merged 11 commits into from
Jan 12, 2021

Conversation

gudmdharalds
Copy link
Contributor

@gudmdharalds gudmdharalds commented Jan 7, 2021

See background in #141.

TODO:

  • Implement options found in list of booleans in Allow configuration of more parameters via repository options file #141 (first list)
  • Add new options to --repo-options-allowed
  • Test new options via repo configuration file
    • Test results-comments-sort
    • Test review-comments-include-severity
    • Test phpcs
    • Test hashes-api
    • Test svg-checks
    • Test autoapprove
    • Test autoapprove-php-nonfunctional-changes
  • Update README
    • Move documenttion of options under heading "Configuration via repository config-file" to the feature documentation itself as possible
    • Document new config-file options:
      • results-comments-sort
      • review-comments-include-severity
      • phpcs
      • hashes-api
      • svg-checks
      • autoapprove
      • autoapprove-php-nonfunctional-changes
  • Run full-unit tests
  • Check automated unit-tests

Note: No need for updated unit-tests.

@gudmdharalds gudmdharalds merged commit b36052b into master Jan 12, 2021
@gudmdharalds gudmdharalds deleted the feature-more-options-from-repo branch January 12, 2021 17:14
@gudmdharalds gudmdharalds restored the feature-more-options-from-repo branch January 12, 2021 17:15
@gudmdharalds gudmdharalds deleted the feature-more-options-from-repo branch January 12, 2021 17:18
@gudmdharalds gudmdharalds added this to the 1.0.0 milestone May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant