Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dev-tools): always update /devtools #985

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Conversation

sjinks
Copy link
Member

@sjinks sjinks commented Dec 5, 2024

  1. Copy dev-tools to both /dev-tools-orig and /dev-tools (the latter destination is required for backward compatibility).
  2. When the container starts, sync tools from /dev-tools-orig to /dev-tools.

This will simplify the logic in VIP CLI (it will not have to find and remove devtools volume every time the environment starts) and ensure that the volume has the latest tools.

VIP CLI PR: Automattic/vip-cli#2139

Update:
3. Switch the base image from alpine to busybox and add a static build of rsync. This reduces the image size from 11.8MB to 3.05MB and eliminates the need to update the image weekly (busybox updates less often and has fewer security vulnerabilities than a full-fledged distro).
4. Make the build process more cache-friendly by making copied files independent on their own layer.

@sjinks sjinks added the Blocked label Dec 5, 2024
@sjinks sjinks self-assigned this Dec 5, 2024
@sjinks sjinks requested a review from a team as a code owner December 5, 2024 04:57
Copy link

github-actions bot commented Dec 5, 2024

Trivy Scan Report

Trivy Returned Empty Report

@sjinks
Copy link
Member Author

sjinks commented Dec 8, 2024

  1. The latest commit switches the base image from alpine to busybox and adds a static build of rsync. This reduces the image size from 11.8MB to 3.05MB and eliminates the need to update the image weekly (busybox updates less often and has fewer security vulnerabilities than a full-fledged distro).
  2. It also makes the build process more cache-friendly by making copied files independent on their own layer.

These updates are friendly to VIP CLI and don't require any changes to the configuration.

@sjinks
Copy link
Member Author

sjinks commented Dec 12, 2024

Merging, because Automattic/vip-cli#2139 is already merged.

@sjinks sjinks merged commit 0addf43 into master Dec 12, 2024
1 check passed
@sjinks sjinks deleted the devtools-update-volume branch December 12, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant