refactor(dev-env): make wordpress init-only container
#2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 2 out of 3 changed files in this pull request and generated no suggestions.
Files not reviewed (1)
- assets/dev-env.lando.template.yml.ejs: Language not supported
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
sjinks
commented
Dec 8, 2024
sjinks
commented
Dec 8, 2024
| LANDO_NO_SCRIPTS: 1 | ||
| LANDO_NEEDS_EXEC: 1 | ||
| initOnly: true | ||
| entrypoint: /usr/bin/rsync -a --chown=${LANDO_HOST_USER_ID}:${LANDO_HOST_GROUP_ID} /wp/ /shared/ |
There was a problem hiding this comment.
${LANDO_HOST_USER_ID} and ${LANDO_HOST_GROUP_ID} will be taken directly from the environment; we don't need to spawn a shell to pass the values to the program.
Because the container is init-only, we don't need Lando scripts to manage permissions either; rsync perfectly understands numeric IDs and does not require the presence of /etc/passwd. This allows us to optimize WordPress images.
sjinks
force-pushed
the
wordpress-init-only
branch
from
2d7c9d1 to
5c0d0f8
Compare
|
Tested under all platforms (except Linux), works as expected. |
rinatkhaziev
approved these changes
Dec 12, 2024
sjinks
force-pushed
the
wordpress-init-only
branch
from
5c0d0f8 to
386888f
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Dev Environment Lando template to make the
wordpressservice init-only (see #1341 for the background). Because we usewordpressonly to provide a volume with WordPress installation, we don't need the container after the initialization stage. Letting the container die peacefully will free up some memory and CPU and reduce the number of mount points.This PR and #2139 will let us merge the
dev-toolsandwordpressservices into one. We will also be able to replace the dependency condition forwordpressfromservice_startedtoservice_completed_successfully; this will simplify the WordPress setup script because Docker will start thephpservice after WordPress files are copied to where they belong.Pull request checklist
New release checklist
Steps to Test
npm run build && npm link.vip dev-env create < /dev/null && vip dev-env start.vip dev-env logs -S wordpressmust show nothing because we bypass Lando.docker ps -a --no-truncmust show the entry point for thewordpressservice as"/usr/bin/rsync -a --chown=1000:1000 /wp/ /shared/"(with the UID and GID of the current user instead of 1000:1000).