refactor(dev-env): bypass Lando entrypoint for auxiliary images #2135
+14
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 1 out of 2 changed files in this pull request and generated no suggestions.
Files not reviewed (1)
- assets/dev-env.lando.template.yml.ejs: Language not supported
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
This was referenced Dec 4, 2024
sjinks
force-pushed
the
update/lando-template
branch
2 times, most recently
from
05ceb37 to
4772c18
Compare
|
I tested the happy path and it's happy, but I would like to test the unhappy path somehow |
sjinks
force-pushed
the
update/lando-template
branch
from
55f3681 to
9db07e3
Compare
sjinks
force-pushed
the
update/lando-template
branch
from
9db07e3 to
8b91294
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Landofile template to completely bypass the Lando entry point for auxiliary images that do not need custom scripts or permissions sweeps.
This:
Pull request checklist
New release checklist
Steps to Test
vip dev-env create -e -A -H -p < /dev/null vip dev-env start docker psghcr.io/automattic/vip-container-images/nginx:latest,elasticsearch:7.17.8,phpmyadmin:5,axllent/mailpit:latest,memcached:1.6-alpine, andmysql:8.4containers must be running, and theirCOMMANDmust not mentionlando-entrypoint;vip dev-env logs -S demo-app-codemust return nothing;vip dev-env logs -S devtoolsmust return nothing;vip dev-env logs -S wordpressmust return nothing;