Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Node.js versions and standardize the format #2098

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

luiztiago
Copy link
Contributor

Description

The ALLOWED_NODEJS_VERSIONS versions in vip validate-preflight contain outdated versions. This PR updates the list of available versions to the latest node versions - 18, 20, 22

Standardize the format options for the vip validate preflight command

Pull request checklist

New release checklist

Steps to Test

  1. Pull down the PR
  2. Run npm run build
  3. run npm run test

Copy link
Contributor

github-actions bot commented Nov 13, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

* trunk:
  Revert "New package release: v3.9.0"
  chore: bump package version to v3.9.0
  Add comment explaining the reason why the limit default value is set manually
  Remove setImmediate
  Validate logs limit argument
  Update socket error handler
  build(deps): bump uuid from 11.0.2 to 11.0.3
  build(deps-dev): bump nock from 13.5.5 to 13.5.6
  fix(dev-env): detection of URLs to replace for multisites (#2081)
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@iamchughmayank
Copy link
Contributor

Validated using:

mytestsite % node ../vip-cli/dist/bin/vip-validate-preflight.js @mytestsite.production --format json > results.json --node-version 18
mytestsite % cat results.json

The json is output as expected with the test results.

Thanks for working on this.

@luiztiago luiztiago merged commit af2ae4e into trunk Nov 14, 2024
15 of 16 checks passed
@luiztiago luiztiago deleted the update/nodejs_versions_and_format branch November 14, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants