Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: table format output #2096

Merged
merged 2 commits into from
Nov 13, 2024
Merged

fix: table format output #2096

merged 2 commits into from
Nov 13, 2024

Conversation

sjinks
Copy link
Member

@sjinks sjinks commented Nov 13, 2024

Description

This PR enables the table format option for the vip logs command to work as expected and for table to be the default output format.

See: BB8-11593

Pull request checklist

New release checklist

Steps to Test

Compare the output of vip logs @env with and without this patch.

@sjinks sjinks added the [Type] Bug Something isn't working label Nov 13, 2024
@sjinks sjinks requested a review from yolih November 13, 2024 08:15
@sjinks sjinks self-assigned this Nov 13, 2024
Copy link
Contributor

github-actions bot commented Nov 13, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@sjinks sjinks force-pushed the BB8-11593 branch 2 times, most recently from f3d5200 to f7d24fd Compare November 13, 2024 08:24
@rinatkhaziev
Copy link
Contributor

Are we sure we want the table a default format?

@yolih
Copy link
Contributor

yolih commented Nov 13, 2024

Whenever possible, VIP-CLI commands that support the --format option should adhere to a standard set of options and default patterns, even if the options and defaults might not seem logical. Adhering to a pattern makes an option more intuitive for a customer to use without having to consult the --help menu.
https://veetoop2.wordpress.com/2024/04/16/standardizing-the-format-option-in-vip-cli/

@sjinks sjinks merged commit 607af95 into trunk Nov 13, 2024
16 checks passed
@sjinks sjinks deleted the BB8-11593 branch November 13, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants