Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the unused --format option from validate media files command #2058

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

saroshaga
Copy link
Contributor

@saroshaga saroshaga commented Oct 16, 2024

Description

The --format option on the vip import validate-files is not a valid one, and does nothing right now.

We're removing it from the help menu, and ensuring that it is not an option that the user can select.

Pull request checklist

New release checklist

Steps to Test

  1. Check out PR.
  2. Run npm run build
  3. Run ./dist/bin/vip-import-validate-files.js -h
  4. Verify that the --format option does not show up

Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

@saroshaga saroshaga added [Status] Needs Review [Status] Needs Docs The feature or update requires an update to our public VIP Documentation labels Oct 16, 2024
Copy link
Contributor

@yolih yolih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for quick action on this.

Copy link
Member

@ariskataoka ariskataoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@saroshaga saroshaga merged commit 677b698 into trunk Oct 17, 2024
16 checks passed
@saroshaga saroshaga deleted the update/remove-format-validate-files branch October 17, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Docs The feature or update requires an update to our public VIP Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants