Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL Import: Switch to wpSitesSDS query #1975

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

mjangda
Copy link
Member

@mjangda mjangda commented Jul 31, 2024

The wpSites query is the legacy one which relies on WP REST API + Jetpack-based lookups and can fail more often than not. When it does fail, it fails to kick off the import as the API returns a partial error and the CLI takes that as a complete failure.

{
	"errors": [
		{
			"message": "Not Found",
			"locations": [
				{
					"line": 24,
					"column": 5
				}
			],
			"path": [
				"apps",
				"edges",
				0,
				"environments",
				2,
				"wpSites"
			],
			"extensions": {
				"code": "wpsites-error"
			},

The SDS one uses the newer and more reliable Site Details Service data. They're interchangeable so no other changes are necessary.

Pull request checklist

New release checklist

Steps to Test

  1. Check out PR.
  2. Run npm run build
  3. Run ./dist/bin/vip-import-sql.js 309 file.sql
  4. Verify import runs without issue.

Copy link
Contributor

github-actions bot commented Jul 31, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

The wpSites query is the legacy one which relies on WP REST API + Jetpack-based lookups and can fail more often than not. The SDS one uses the newer and more reliable Site Details Service data. They're interchangeable so no other changes are necessary.
@mjangda mjangda force-pushed the update/import-sql-sds branch from e3b76c9 to bea0771 Compare July 31, 2024 18:06
Copy link

@mjangda mjangda merged commit ab5259f into trunk Jul 31, 2024
16 checks passed
@mjangda mjangda deleted the update/import-sql-sds branch July 31, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants