Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dev-env): migrate from @lando/phpmyadmin to phpmyadmin Docker image #1920

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

sjinks
Copy link
Member

@sjinks sjinks commented Jul 1, 2024

Description

The @lando/phpmyadmin plugin uses the old Docker image, phpmyadmin/phpmyadmin. That image is only built for the linux/amd64 architecture and does not work on AEM CPUs (Mac Mx chips).

We replace the plugin in this PR with the newer multiplatform phpmyadmin image.

Ref: 188043-z
Ref: https://hub.docker.com/r/phpmyadmin/phpmyadmin (the image used by Lando)
Ref: https://hub.docker.com/_/phpmyadmin (the multiplatform image)

Pull request checklist

New release checklist

Steps to Test

Create a dev environment with phpMyAdmin enabled, start it, and ensure that it works and that Docker does not complain about the wrong architecture.

@sjinks sjinks requested a review from rinatkhaziev July 1, 2024 19:44
@sjinks sjinks self-assigned this Jul 1, 2024
Copy link
Contributor

github-actions bot commented Jul 1, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

sonarqubecloud bot commented Jul 1, 2024

@sjinks sjinks merged commit 8e82901 into trunk Jul 1, 2024
16 checks passed
@sjinks sjinks deleted the update/pma branch July 1, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants