Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev-env): demo code is displayed as [demo-image] #1852

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

sjinks
Copy link
Member

@sjinks sjinks commented Jun 4, 2024

Description

There was an inconsistency in how the demo code was displayed in vip dev-env info --extended.
For example, if we invoke vip dev-env create -u demo < /dev/null, both MU Plugins and the Application Code will use a demo image, but it will be displayed differently:

$ vip dev-env info --extended | grep -E 'PLUGINS|CODE'
 MU PLUGINS        demo                                                                                               
 APP CODE          [demo-image]                                                                                       

This PR makes this consistent: [demo-image]

Pull request checklist

New release checklist

Steps to Test

See above.

@sjinks sjinks added the [Type] Bug Something isn't working label Jun 4, 2024
@sjinks sjinks self-assigned this Jun 4, 2024
Copy link
Contributor

github-actions bot commented Jun 4, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@sjinks sjinks force-pushed the fix/component-display branch from 5ffe851 to 8825c6d Compare June 4, 2024 12:03
Copy link

sonarqubecloud bot commented Jun 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sjinks sjinks merged commit 4c9de61 into trunk Jun 5, 2024
16 checks passed
@sjinks sjinks deleted the fix/component-display branch June 5, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants