-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new lines after error file URLs #1830
Add new lines after error file URLs #1830
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
I've wondering if we should remove the <link>
from Downloading from <link>
, to make it cleaner?
Also, @aagam-shah left some feedback yesterday that we should probably remove the & the data is retained for 7 days since the completion of the import
phrase from the notice, and instead rely on the docs. What do you feel?
I do think it's nice to be able to access the link. But perhaps it could be printed below the |
Sorry if I was not clear, I meant that we should show the message that we have as-is even though the customer doesn't say YES to download the file because customer might not know the error file will not be available after 7 days if they don't download the file. |
If we want to keep it, then it should be fine as is. |
Quality Gate passedIssues Measures |
Description
Adds new lines after the error file URL and paths. Currently they are not clickable (in iTerm2 at least).
Pull request checklist
New release checklist
Steps to Test
npm run build
./dist/bin/vip-import-media-status.js @<site_id>.production
n
to the promptDownload file import errors report now?