-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add download failure details from url provided by import api to media import command #1820
Add download failure details from url provided by import api to media import command #1820
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment in Slack, but otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also handle the case when the errors file has been deleted from s3 (after 7 days)
What message do we want to show then?
1a8c746
to
f2ffa9e
Compare
f2ffa9e
to
e771ae7
Compare
Modify expiration message Rename output functions signatures Co-authored-by: Sarosh Aga <[email protected]>
Quality Gate passedIssues Measures |
Description
This PR uses the failure details URL for the import media command.
Pull request checklist
New release checklist
Changelog Description
Media import: Add option to download failure details logs from URL returned in the media import request response body.
Steps to Test
Obs.: This test requires a locall VIP API public up and running.
npm run build
Scenario 1:
VIP_PROXY="" API_HOST={ LOCAL_VIP_API_PUBLIC_URL } node ./dist/bin/vip-import-media.js @{ TEST_SITE_ID }.{ ENV_SITE } { MEDIA_TO_BE_IMPORTED_URL }
The output should contain a message about the errors and a prompt as:
Scenario 2:
Repeat step 1