fix(phpmyadmin): Add step to wait for PhpMyAdmin readiness. #1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
aswasif007
commented
May 2, 2024
aswasif007
commented
May 2, 2024
saroshaga
reviewed
May 2, 2024
saroshaga
reviewed
May 3, 2024
saroshaga
reviewed
May 3, 2024
aswasif007
force-pushed
the
forno-1953/update/pma-cli
branch
from
4423c33 to
9097297
Compare
saroshaga
reviewed
May 3, 2024
saroshaga
reviewed
May 3, 2024
saroshaga
reviewed
May 3, 2024
saroshaga
reviewed
May 3, 2024
|
Update: upon an offline discussion with Sarosh, we agreed to create a status/healthcheck endpoint in the phpMyAdmin itself, which will allow us to detect readiness in a cleaner way. |
aswasif007
force-pushed
the
forno-1953/update/pma-cli
branch
from
d3defb4 to
67c8b89
Compare
saroshaga
reviewed
May 22, 2024
aswasif007
force-pushed
the
forno-1953/update/pma-cli
branch
from
c42f28d to
6cb420b
Compare
saroshaga
approved these changes
May 23, 2024
Also remane LB_DELAY -> PROCESSING
aswasif007
force-pushed
the
forno-1953/update/pma-cli
branch
from
a0047d1 to
746d705
Compare
|
Comment on lines
+168
to
+172
| const resp = await fetch( url, { | ||
| method: 'GET', | ||
| redirect: 'manual', | ||
| agent: agent ?? undefined, | ||
| } ); |
There was a problem hiding this comment.
Should we add some cache-ignoring/cache-busting headers/cookies here? Or switch to POST here? It will at least eliminate the possibility that it's not the cache that's causing issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After spinning up the necessary pod to run PhpMyAdmin, we have to wait for the LB to be propagated, so that the requests to the PhpMyAdmin link are served the by PhpMyAdmin pod. In this PR, we are adding a step to wait to see the LB routing is happening before we generate an access.
Pull request checklist
Steps to Test
npm run buildnode ./dist/bin/vip db phpmyadmin @<app>.<env>. This should be run on an environment for which PMA is not enabled yet.