Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: underscore is allowed in environment name #1778

Merged
merged 1 commit into from
Apr 15, 2024
Merged

fix: underscore is allowed in environment name #1778

merged 1 commit into from
Apr 15, 2024

Conversation

sjinks
Copy link
Member

@sjinks sjinks commented Apr 15, 2024

Description

This PR adds _ to the list of the allowed characters for the environment name.

Please have a look at BB8-11225 for the full description.

Pull request checklist

New release checklist

Steps to Test

I have added a unit test for this case; CI must pass.

@sjinks sjinks added [Type] Bug Something isn't working [Status] Needs Review labels Apr 15, 2024
@sjinks sjinks self-assigned this Apr 15, 2024
Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sjinks sjinks merged commit 416d702 into trunk Apr 15, 2024
17 checks passed
@sjinks sjinks deleted the BB8-11225 branch April 15, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants