Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to descriptions and examples for vip backup #1766

Merged
merged 4 commits into from
Apr 18, 2024

Conversation

yolih
Copy link
Contributor

@yolih yolih commented Apr 9, 2024

Description

Updated the voice, tense, and format of command descriptions, examples, and usage models for the vip backup command group to follow the VIP-CLI style guide.

Pull request checklist

New release checklist

Steps to Test

Observe the results of the --help display for impacted commands:

  • vip backup
    • vip backup db

@yolih yolih added the [Type] Documentation Pull request to update documentation. label Apr 9, 2024
@yolih yolih requested a review from terriann April 9, 2024 23:35
Copy link
Contributor

github-actions bot commented Apr 9, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

src/bin/vip-backup-db.ts Outdated Show resolved Hide resolved
src/bin/vip.js Outdated Show resolved Hide resolved
src/bin/vip-backup.ts Outdated Show resolved Hide resolved
src/bin/vip-backup-db.ts Outdated Show resolved Hide resolved
src/bin/vip.js Show resolved Hide resolved
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
6.7% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@terriann terriann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me 🎉

@@ -27,7 +27,7 @@ const runCmd = async function () {
cmd
.command( 'logout', 'Logout from your current session' )
.command( 'app', 'List and modify your VIP applications' )
.command( 'backup', 'Generate a backup for VIP applications' )
.command( 'backup', 'Generate a backup of an environment.' )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this match the text above?

Generate a new database backup of an environment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sooo... this touches on our grander strategic discussion around the patterns that our VIP-CLI command library should follow in order to be truly extensible.
By adding the command vip backup, we should be doing so because we believe that we will be adding a group of subcommands related to backup (e.g., db, media).
In good faith that this might be the direction that we are heading in for vip backup, we are choosing to describe that command in a more neutral manner.

@yolih yolih merged commit 737d4ad into trunk Apr 18, 2024
17 checks passed
@yolih yolih deleted the update/docs-pt-vip-backup branch April 18, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Documentation Pull request to update documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants