-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to descriptions and examples for vip backup #1766
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me 🎉
@@ -27,7 +27,7 @@ const runCmd = async function () { | |||
cmd | |||
.command( 'logout', 'Logout from your current session' ) | |||
.command( 'app', 'List and modify your VIP applications' ) | |||
.command( 'backup', 'Generate a backup for VIP applications' ) | |||
.command( 'backup', 'Generate a backup of an environment.' ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this match the text above?
Generate a new database backup of an environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sooo... this touches on our grander strategic discussion around the patterns that our VIP-CLI command library should follow in order to be truly extensible.
By adding the command vip backup
, we should be doing so because we believe that we will be adding a group of subcommands related to backup
(e.g., db
, media
).
In good faith that this might be the direction that we are heading in for vip backup
, we are choosing to describe that command in a more neutral manner.
Description
Updated the voice, tense, and format of command descriptions, examples, and usage models for the
vip backup
command group to follow the VIP-CLI style guide.Pull request checklist
New release checklist
Steps to Test
Observe the results of the --help display for impacted commands:
vip backup
vip backup db