Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to descriptions and examples for vip db #1765

Merged
merged 6 commits into from
Apr 18, 2024
Merged

Conversation

yolih
Copy link
Contributor

@yolih yolih commented Apr 9, 2024

Description

Updated the voice, tense, and format of command descriptions, examples, and usage models for the vip db command group to follow the VIP-CLI style guide.

Pull request checklist

New release checklist

Steps to Test

Observe the results of the --help display for impacted commands:

  • vip db
    • vip db phpmyadmin

@yolih yolih added the [Type] Documentation Pull request to update documentation. label Apr 9, 2024
@yolih yolih requested a review from terriann April 9, 2024 22:41
Copy link
Contributor

github-actions bot commented Apr 9, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

src/bin/vip-db.ts Outdated Show resolved Hide resolved
src/bin/vip.js Outdated Show resolved Hide resolved
@yolih yolih requested a review from a team April 16, 2024 22:18
src/bin/vip-db-phpmyadmin.ts Outdated Show resolved Hide resolved
src/bin/vip-db.ts Outdated Show resolved Hide resolved
src/bin/vip.js Outdated Show resolved Hide resolved
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@terriann terriann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me!

@yolih yolih merged commit f733e9a into trunk Apr 18, 2024
17 checks passed
@yolih yolih deleted the update/docs-pt-vip-db branch April 18, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Documentation Pull request to update documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants