Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the export command group according to VIP-CLI style guide #1741

Merged
merged 4 commits into from
Mar 28, 2024
Merged

Updated the export command group according to VIP-CLI style guide #1741

merged 4 commits into from
Mar 28, 2024

Conversation

yolih
Copy link
Contributor

@yolih yolih commented Mar 25, 2024 •
edited
Loading

Description

Updated the voice, tense, and format of command descriptions, examples, and usage models for the vip export command group to follow the VIP-CLI style guide.

Pull request checklist

New release checklist

@yolih yolih added the [Type] Documentation Pull request to update documentation. label Mar 25, 2024
@yolih yolih requested a review from terriann March 25, 2024 20:58
terriann
terriann requested changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@terriann terriann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I included some feedback on example usage descriptions

src/bin/vip-export-sql.js Outdated Show resolved Hide resolved
src/bin/vip-export-sql.js Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@yolih yolih requested a review from a team March 27, 2024 16:40
@yolih yolih requested a review from terriann March 28, 2024 01:46
terriann
terriann approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@terriann terriann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@yolih yolih merged commit f974f12 into trunk Mar 28, 2024
16 checks passed
@yolih yolih deleted the update/docs-pt-vip-export branch March 28, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aswasif007 aswasif007 aswasif007 approved these changes

@terriann terriann terriann approved these changes

Assignees
No one assigned
Labels
[Type] Documentation Pull request to update documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yolih @terriann @aswasif007