Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes text so that it doesn't reference "the above tables" when tables are not displayed #1731

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

brunobasto
Copy link
Contributor

Description

Fixes text so that it doesn't reference "the above tables" when tables are not displayed.

Pull request checklist

New release checklist

Steps to Test

  1. Check out PR.
  2. Run npm run build
  3. Run ./dist/bin/vip-import-sql.js -a 3800 sqlFile.sql -s (multisite)
  4. Run ./dist/bin/vip-import-sql.js -a 8758 sqlFile.sql -s (multisite)
  5. Verify the text output only mentions "above tables" when tables are actually listed

@sjinks
Copy link
Member

sjinks commented Mar 21, 2024

@brunobasto could you please take a look at the conflict?

@brunobasto brunobasto force-pushed the fix/broken-text-reference-to-above-tables branch from 4ab9102 to 5e49226 Compare April 1, 2024 14:25
Copy link

sonarqubecloud bot commented Apr 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sjinks sjinks merged commit 6e29d32 into trunk Apr 2, 2024
16 checks passed
@sjinks sjinks deleted the fix/broken-text-reference-to-above-tables branch April 2, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants