vip app deploy - Allow passing in a deploy key with env variable #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebeccahum
force-pushed
the
add/passing-byor-key
branch
from
610ff24 to
3a20309
Compare
chriszarate
reviewed
Mar 5, 2024
chriszarate
reviewed
Mar 5, 2024
chriszarate
reviewed
Mar 5, 2024
rebeccahum
force-pushed
the
add/passing-byor-key
branch
2 times, most recently
from
5415f83 to
478ef8c
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
rebeccahum
force-pushed
the
add/passing-byor-key
branch
from
478ef8c to
7cd703c
Compare
rebeccahum
force-pushed
the
add/passing-byor-key
branch
6 times, most recently
from
331bc30 to
5cbeb31
Compare
chriszarate
reviewed
Mar 5, 2024
chriszarate
reviewed
Mar 5, 2024
chriszarate
approved these changes
Mar 5, 2024
luiztiago
approved these changes
Mar 6, 2024
mjangda
reviewed
Mar 6, 2024
rebeccahum
force-pushed
the
add/passing-byor-key
branch
from
ddd911a to
c1749e9
Compare
rebeccahum
force-pushed
the
add/passing-byor-key
branch
from
f1b50f6 to
593df96
Compare
rebeccahum
force-pushed
the
add/passing-byor-key
branch
from
72ea73e to
a642ccc
Compare
rebeccahum
force-pushed
the
add/passing-byor-key
branch
from
d17f8fc to
305ee4e
Compare
|
chriszarate
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows us to pass in the Custom Deploy Key into
vip app deploy.Also refactors
API()to allow using acustomAuthToken. RemovesheadersinHttpLink()to allow for theauthLinkto dynamically set by context.Pull request checklist
New release checklist
Steps to Test
CUSTOM_DEPLOY_KEY=$token vip @<env id>.production app deploy ~/Desktop/vip-go-skeleton.zip