Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update publish docs request parameters #1688

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

seanlanglands
Copy link
Contributor

@seanlanglands seanlanglands commented Feb 8, 2024

Description

Our improved VIP-CLI command reference library is now live on docs.wpvip.com, so we need to update this workflow's curl parameters to target the correct ingest endpoint.

Note – The request method was explicitly changed to PUT as we're replacing the entirety of commands with the updated payload generated by helpers/generate-docs.js.

I see that this existing workflow has yet to be triggered in recent releases. Would that be because GitHub Actions was not used to publish recent releases? Would a note in /docs/RELEASING.md#alternative-methods-of-releasing be a suitable place to document manually running this workflow when using an alternative method?

We ultimately want to ensure our public documentation is always in sync with releases.

Pull request checklist

Copy link

sonarqubecloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@seanlanglands seanlanglands merged commit cf3dd85 into trunk Feb 8, 2024
16 checks passed
@seanlanglands seanlanglands deleted the feature/update-publish-docs-workflow branch February 8, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants