Track errors encounted at get-status #1672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
saroshaga
approved these changes
Jan 30, 2024
aswasif007
added a commit
that referenced
this pull request
Feb 1, 2024
* Add phpmyadmin command * Use opn types from package.json instead * Lint fixes * Add tracking and testing * Display error message * Add `db` command And move `phpmyadmin` as a subcommand of the db command * Remove unnecessary command for package.json * Fix lint * Add accidentally removed global.d.ts * Display read-only disclaimer for vip-db-phpmyadmin cmd (#1579) * Replace opn by open lib * Add step to enable PHPMyAdmin in the phpmyadmin command (#1665) * Add step to enable pma * Refactor for clarity - make function name clearer - add return types * Fix and improve unit test * Make function names even clearer --------- Co-authored-by: Sarosh Aga <[email protected]> * Add event tracking for PMA enable failures (#1667) * Add event tracking for PMA enable failures * Refactor * Bring back empty line * Print progress steps properly on error scenarios --------- Co-authored-by: Ahmed Sayeed Wasif <[email protected]> * Track errors encounted at get-status (#1672) * Update appQuery to reduce fields --------- Co-authored-by: Abdullah bin Kasim <[email protected]> Co-authored-by: Sarosh Aga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are
try-catching insidegetStatus, as a result the error was not bubbling up outside that function to be tracked in pendo. We are fixing it here by removing the try-catch.