Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: regex vulnerable to super-linear runtime #1639

Merged
merged 2 commits into from
Jan 12, 2024
Merged

fix: regex vulnerable to super-linear runtime #1639

merged 2 commits into from
Jan 12, 2024

Conversation

sjinks
Copy link
Member

@sjinks sjinks commented Jan 10, 2024

Description

  • The regular expression used to parse DOCKER_HOST is vulnerable to super-linear runtime due to backtracking; in theory (although unlikely), it can be exploited to cause a denial of service (ref)
  • The regular expression used to extract the version of a PHP image is vulnerable to super-linear runtime due to backtracking (ref)

Pull request checklist

New release checklist

Steps to Test

The existing tests cover the change.

@sjinks sjinks added [Type] Bug Something isn't working [Status] Needs Review labels Jan 10, 2024
@sjinks sjinks self-assigned this Jan 10, 2024
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sjinks sjinks merged commit 27f0334 into trunk Jan 12, 2024
14 checks passed
@sjinks sjinks deleted the fix/regex branch January 12, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants