Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(validate-sql): Display matched site-urls #1630

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

aswasif007
Copy link
Contributor

Description

The output of the vip import validate-sql command looks like this:

✅ ALTER TABLE statement was found 0 times.
✅ SET UNIQUE_CHECKS = 0 was found 0 times.
siteurl

Here, we are adding the actual site url alongside the siteurl text:

- siteurl
+ siteurl https://example.com

Steps to Test

  1. Check out PR.
  2. Run npm run build
  3. Export an sql file using the export command: Example: vip export sql @app.env
  4. Unzip the exported sql file: gunzip <filepath>
  5. Run the validate-sql command: `node ./dist/bin/vip import validate-sql <unzipped_filepath>

@aswasif007 aswasif007 requested a review from a team January 2, 2024 13:10
Copy link

sonarqubecloud bot commented Jan 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@aswasif007 aswasif007 merged commit 8156c33 into trunk Jan 2, 2024
14 checks passed
@aswasif007 aswasif007 deleted the bb8-10518/add/home-url branch January 2, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants