fix: Properly propagate quotes #1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjinks
approved these changes
Dec 28, 2023
|
@aswasif007 I added some failing test cases. Revert if I am misunderstanding the issue. I do wonder if we should fix this issue centrally in Parker rather than parsing and validating in the client. |
saroshaga
approved these changes
Dec 29, 2023
aswasif007
commented
Dec 29, 2023
aswasif007
commented
Jan 12, 2024
aswasif007
force-pushed
the
bb8-10702/fix/quote-issue
branch
from
02ca1ac to
5941cca
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix an issue with propagating quotes to wp shell. Here is the issue with current implementation:
If you execute
vip @app.env -- wp --foo='bar1 "bar2" "bar3"'the command that gets executed in the shell is:vip @app.env -- wp --foo="bar1 "bar2" "bar3"". This PR fixes that quoting issue.