feat(phpmyadmin): Add vip db phpmyadmin command
#1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saroshaga
reviewed
Oct 9, 2023
|
Hope you don't mind, I made a tiny bit of change to make all our lives easier in the typescript land. |
|
Types for graphql queries can be generated according to the instructions here: https://github.com/Automattic/vip-cli/blob/trunk/CONTRIBUTING.md#generating-the-types |
🔔 Note: Released with
|
aswasif007
changed the title
vip phpmyadmin commandvip db phpmyadmin command
sjinks
force-pushed
the
trunk
branch
2 times, most recently
from
ce8ac7d to
50cb74a
Compare
aswasif007
force-pushed
the
feature/phpmyadmin-cmd
branch
from
8c8e829 to
485f43f
Compare
🔔 Note: Released with @next tag for testing: v2.36.2-dev.0 🔔 |
aswasif007
force-pushed
the
feature/phpmyadmin-cmd
branch
from
61db116 to
73cafbd
Compare
|
🔔 Note: Released with
|
aswasif007
force-pushed
the
feature/phpmyadmin-cmd
branch
from
73cafbd to
1a83716
Compare
🔔 Note: Released with
|
And move `phpmyadmin` as a subcommand of the db command
* Add step to enable pma * Refactor for clarity - make function name clearer - add return types * Fix and improve unit test * Make function names even clearer --------- Co-authored-by: Sarosh Aga <[email protected]>
* Add event tracking for PMA enable failures * Refactor * Bring back empty line * Print progress steps properly on error scenarios --------- Co-authored-by: Ahmed Sayeed Wasif <[email protected]>
aswasif007
force-pushed
the
feature/phpmyadmin-cmd
branch
from
736a9ca to
0deb40d
Compare
🔔 Note: Released with @next tag for open beta: v2.38.0-dev.1 🔔 |
|
saroshaga
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, we are adding a new command
vip db phpmyadminwhich generates a URL tophpmyadmin, and opens in the default browser.Steps to Test
npm run build./dist/bin/vip-db-phpmyadmin.js @6721.production/.wpvip/phpmyadmin/?token=...prefix in your browser.