Update eslint-plugin-wpvip to 0.5.8, Prettier updates #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriszarate
changed the title
sjinks
reviewed
Jun 22, 2023
Comment on lines
114
to
159
| const result = await cliTest.spawn( [ | ||
| process.argv[ 0 ], | ||
| vipDevEnvCreate, | ||
| '--slug', slug, | ||
| '--app-code', 'image', | ||
| '--title', expectedTitle, | ||
| '--multisite', `${ expectedMultisite }`, | ||
| '--php', expectedPhpVersion, | ||
| '--wordpress', expectedWordPressVersion, | ||
| '--mu-plugins', 'image', | ||
| '-e', `${ expectedElasticsearch }`, | ||
| '-p', `${ expectedPhpMyAdmin }`, | ||
| '-x', `${ expectedXDebug }`, | ||
| '-A', `${ expectedMailpit }`, | ||
| '-H', `${ expectedPhoton }`, | ||
| ], { env }, true ); | ||
| const result = await cliTest.spawn( | ||
| [ | ||
| process.argv[ 0 ], | ||
| vipDevEnvCreate, | ||
| '--slug', | ||
| slug, | ||
| '--app-code', | ||
| 'image', | ||
| '--title', | ||
| expectedTitle, | ||
| '--multisite', | ||
| `${ expectedMultisite }`, | ||
| '--php', | ||
| expectedPhpVersion, | ||
| '--wordpress', | ||
| expectedWordPressVersion, | ||
| '--mu-plugins', | ||
| 'image', | ||
| '-e', | ||
| `${ expectedElasticsearch }`, | ||
| '-p', | ||
| `${ expectedPhpMyAdmin }`, | ||
| '-x', | ||
| `${ expectedXDebug }`, | ||
| '-A', | ||
| `${ expectedMailpit }`, | ||
| '-H', | ||
| `${ expectedPhoton }`, | ||
| ], | ||
| { env }, | ||
| true | ||
| ); |
There was a problem hiding this comment.
IMHO, the original version was more readable :-(
There was a problem hiding this comment.
I added exemptions for this and similar invocations with // prettier-ignore
sjinks
approved these changes
Jun 22, 2023
chriszarate
force-pushed
the
update/eslint-wpvip-0.5.8
branch
from
0151c2d to
6252b96
Compare
chriszarate
force-pushed
the
update/eslint-wpvip-0.5.8
branch
from
6252b96 to
a998aca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
eslint-plugin-wpvipto0.5.8which contains additional lint rules and expands Prettier config to work with JSON, Markdown, and YAML files.wp-prettier.editorconfignpmscriptseslint-disable-next-lineWhat should I review?
Since this is a formatting-heavy PR, I recommend reviewing commit-by-commit and ignoring the "Prettier formatting" commits. Code changes to address lint errors deserve attention, as do any changes to
package.json,.eslintrc, and any changed ignore files.It's not particularly helpful to review the formatting changes themselves, since they are automated and well-tested upstream.
Steps to Test
npm run formatnpm run lint