refactor(dev-env): bypass Lando entrypoint for auxiliary images

Automattic · Dec 4, 2024 · ebac6b7 · ebac6b7
1 parent 4f30fd5
commit ebac6b7
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 31 deletions.
diff --git a/assets/dev-env.lando.template.yml.ejs b/assets/dev-env.lando.template.yml.ejs
@@ -19,33 +19,25 @@ services:
     type: compose
     services:
       image: ghcr.io/automattic/vip-container-images/dev-tools:0.9
-      command: /bin/true
       volumes:
         - devtools:/dev-tools
         - scripts:/scripts
-      environment:
-        LANDO_NO_USER_PERMS: 1
-        LANDO_NO_SCRIPTS: 1
-        LANDO_NEEDS_EXEC: 1
     volumes:
       devtools: {}
       scripts:
     initOnly: true
+    entrypoint: /bin/true
 
   nginx:
     type: compose
     ssl: true
     sslExpose: false
     services:
       image: ghcr.io/automattic/vip-container-images/nginx:latest
-      command: nginx -g "daemon off;"
-      environment:
-        LANDO_NEEDS_EXEC: 1
-        LANDO_WEBROOT_USER: nginx
-        LANDO_WEBROOT_GROUP: nginx
       volumes:
         - ./nginx/extra.conf:/etc/nginx/conf.extra/extra.conf
 <% wpVolumes() %>
+    entrypoint: /usr/sbin/nginx -g "daemon off;"
 
   php:
     type: compose
@@ -118,18 +110,13 @@ services:
     type: compose
     services:
       image: memcached:1.6-alpine
-      command: memcached -m 64
-      environment:
-        LANDO_NO_USER_PERMS: 1
-        LANDO_NO_SCRIPTS: 1
-        LANDO_NEEDS_EXEC: 1
+    entrypoint: /usr/local/bin/memcached -m 64
 
 <% if ( phpmyadmin ) { %>
   phpmyadmin:
     type: compose
     services:
       image: phpmyadmin:5
-      command: /docker-entrypoint.sh apache2-foreground
       environment:
         MYSQL_ROOT_PASSWORD: ''
         PMA_HOSTS: database
@@ -145,30 +132,28 @@ services:
         - pma_www:/var/www/html
     volumes:
       pma_www:
+    entrypoint: /docker-entrypoint.sh apache2-foreground
 <% } %>
 
 <% if ( elasticsearch ) { %>
   elasticsearch:
     type: compose
     services:
       image: elasticsearch:7.17.8
-      command: /usr/local/bin/docker-entrypoint.sh
       environment:
         ELASTICSEARCH_IS_DEDICATED_NODE: 'no'
         ELASTICSEARCH_CLUSTER_NAME: 'bespin'
         ELASTICSEARCH_NODE_NAME: 'lando'
         ELASTICSEARCH_PORT_NUMBER: 9200
         discovery.type: 'single-node'
         xpack.security.enabled: 'false'
-        LANDO_NO_USER_PERMS: 1
-        LANDO_NO_SCRIPTS: 1
-        LANDO_NEEDS_EXEC: 1
       ports:
         - ":9200"
       volumes:
         - search_data:/usr/share/elasticsearch/data
     volumes:
       search_data:
+    entrypoint: /usr/local/bin/docker-entrypoint.sh
 <% } %>
 
   wordpress:
@@ -215,7 +200,6 @@ services:
     type: compose
     services:
       image: ghcr.io/automattic/vip-container-images/skeleton:latest
-      command: exit 0
       volumes:
         - clientcode_clientmuPlugins:/clientcode/client-mu-plugins
         - clientcode_images:/clientcode/images
@@ -233,34 +217,28 @@ services:
       clientcode_themes: {}
       clientcode_vipconfig: {}
     initOnly: true
+    entrypoint: /bin/true
 <% } %>
 
 <% if ( mailpit ) { %>
   mailpit:
     type: compose
     services:
       image: axllent/mailpit:latest
-      command: /mailpit
       ports:
         - ":1025"
         - ":8025"
-      environment:
-        LANDO_NO_USER_PERMS: 1
-        LANDO_NEEDS_EXEC: 1
+    entrypoint: /mailpit
 <% } %>
 
 <% if ( photon ) { %>
   photon:
     type: compose
     services:
       image: ghcr.io/automattic/vip-container-images/photon:latest
-      command: /usr/sbin/php-fpm
-      environment:
-        LANDO_NO_USER_PERMS: 1
-        LANDO_NO_SCRIPTS: 1
-        LANDO_NEEDS_EXEC: 1
       volumes:
         - ./uploads:/usr/share/webapps/photon/uploads:ro
+    entrypoint: /usr/sbin/php-fpm
 <% } %>
 
 tooling:

diff --git a/src/lib/constants/dev-environment.ts b/src/lib/constants/dev-environment.ts
@@ -49,4 +49,4 @@ export const DEV_ENVIRONMENT_DEFAULTS = {
 	phpVersion: Object.keys( DEV_ENVIRONMENT_PHP_VERSIONS )[ 0 ],
 } as const;
 
-export const DEV_ENVIRONMENT_VERSION = '2.1.2';
+export const DEV_ENVIRONMENT_VERSION = '2.1.3';