Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Modify expiration message
Rename output functions signatures

Co-authored-by: Sarosh Aga <[email protected]>
  • Loading branch information
ariskataoka and saroshaga authored May 9, 2024
1 parent e771ae7 commit a7eab97
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/lib/media-import/status.ts
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ Downloading errors details from ${ failureDetailsUrl }...
`⚠️ Error details can be found on ${ chalk.bold(
failureDetailsUrl
) } ${ chalk.italic.yellow(
'(This link will be valid for the next 15 minutes. The report is retained for 7 days since the import was run.)'
'(This link will be valid for the next 15 minutes. The report is retained for 7 days from the completion of the import.)'
) }. `
) }\n`;
progressTracker.print( { clearAfter: true } );
Expand All @@ -332,7 +332,7 @@ Downloading errors details from ${ failureDetailsUrl }...
await exportFailureDetails( failureDetailsErrors );
}

function linkExpiredOutput( results: AppEnvironmentMediaImportStatus ) {
function printFileErrorsReportLinkExpiredError( results: AppEnvironmentMediaImportStatus ) {

Check warning on line 335 in src/lib/media-import/status.ts

View workflow job for this annotation

GitHub Actions / Lint

'printFileErrorsReportLinkExpiredError' is defined but never used

Check warning on line 335 in src/lib/media-import/status.ts

View workflow job for this annotation

GitHub Actions / Lint

'printFileErrorsReportLinkExpiredError' is defined but never used

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused function printFileErrorsReportLinkExpiredError.
if (
results.filesTotal &&
results.filesProcessed &&
Expand All @@ -345,7 +345,7 @@ Downloading errors details from ${ failureDetailsUrl }...
}
}

async function exportLocallyOutput(
async function printFailureDetails(

Check warning on line 348 in src/lib/media-import/status.ts

View workflow job for this annotation

GitHub Actions / Lint

'printFailureDetails' is defined but never used

Check warning on line 348 in src/lib/media-import/status.ts

View workflow job for this annotation

GitHub Actions / Lint

'printFailureDetails' is defined but never used

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused function printFailureDetails.
fileErrors: Maybe< AppEnvironmentMediaImportStatusFailureDetailsFileErrors >[],
results: AppEnvironmentMediaImportStatus
) {
Expand Down

0 comments on commit a7eab97

Please sign in to comment.