Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update template and parts directories #5107

Closed
wants to merge 2 commits into from
Closed

Conversation

matiasbenedetto
Copy link
Member

@matiasbenedetto matiasbenedetto commented Nov 26, 2021

Changes proposed in this Pull Request:

Renaming folders:
block-templates -> templates
block-template-parts -> parts
Following the new Gutenberg convention: WordPress/gutenberg#36647

Related issue(s):

#5105

@matiasbenedetto matiasbenedetto self-assigned this Nov 26, 2021
@matiasbenedetto matiasbenedetto linked an issue Nov 26, 2021 that may be closed by this pull request
@MaggieCabrera
Copy link
Contributor

Just a heads up, I think git mv is cleaner for this (in terms of files changed)

@matiasbenedetto
Copy link
Member Author

Ohh, I never used git mv. 😅 It seems there are different opinions about if it is the same as mv or not.
oreilly, gitFaq, StackOverflow. I will create a new PR to test if we can see any difference. 🤔

@matiasbenedetto
Copy link
Member Author

The other PR using git mv instead of mv.

@MaggieCabrera
Copy link
Contributor

Ohh, I never used git mv. 😅 It seems there are different opinions about if it is the same as mv or not. oreilly, gitFaq, StackOverflow. I will create a new PR to test if we can see any difference. 🤔

yeah looks like they are basically the same" I was hoping we would maintain the history for the moved files while using github's history page, but looks like it doesn't work either way, sorry I made you do the same thing twice!

@scruffian
Copy link
Member

Closing in favour of #5108

@scruffian scruffian closed this Nov 30, 2021
@scruffian scruffian deleted the update/5105 branch November 30, 2021 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blockbase: Update template directories
3 participants