-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blockbase comments block refactor #4535
Conversation
8329da5
to
2118ae6
Compare
Thanks so much for the quick review! I think I fixed all the points above, this is ready for another review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks Maggie! We may refine more eventually, but this is a great starting point for these, and it's way nicer than what we had before. 🙌
One very tiny thing I noticed in Seedlet Blocks: The spacing above and below each comment should be equal, but right now there's more space at the bottom than at the top:
Feel free to fix that here or in a followup PR! Thank you!
89975f0
to
d738ee5
Compare
Fixed the last thing and bringing this in |
Changes proposed in this Pull Request:
This PR refactors the Post comments block for Blockbase and all its children according to what's discussed on #4515 and #4531
There was some redundant CSS on some of the themes and some that could be refactored into Blockbase to work for all the children.
This is the before and after:
Blockbase:
Seedlet:
Mayland:
Quadrat:
Geologist:
Skatepark:
Related issue(s):
Closes #4515
Partially addresses #4531